fix: validate URL scheme before openExternal in linkifier#11291
Open
uadhran wants to merge 1 commit into
Open
Conversation
Terminal output matching the URL regex could contain arbitrary schemes (file://, data:, javascript:, custom protocol handlers). Added an allowlist check (http/https/ftp/mailto/ssh) in both the URLHandler and xterm's built-in linkHandler before calling openExternal().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fix
Severity: Medium
The linkifier URLHandler and xterm built-in linkHandler called openExternal() with any URL matched from terminal output, without validating the scheme. The URL regex accepts any 3-9 letter scheme, so a malicious SSH server could print a file://, data:, or custom protocol URL and have it opened when the user clicks it.
Fix
Added an allowlist check (http, https, ftp, mailto, ssh) in both call sites before invoking openExternal().
Files changed:
Note: IPHandler (prepends http://) and BaseFileHandler (prepends file://) are intentional and unchanged.