fix(opencode): wait for shell output before returning#30003
Open
dstaple wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #30001
Type of change
What does this PR do?
Fixes a race in
ShellToolwhere the process exit can complete before the stdout/stderr stream has fully drained.The shell output reader already runs in a forked fiber, but the final result was built without waiting for that fiber. This PR joins the output-reader fiber before computing the final shell output, so emitted output is not reported as
(no output)or truncated.I also added a test which repros the issue (fails) on dev but passes on this branch.
How did you verify your code works?
bun testbun typecheckbun devbun devinstance and confirmed output was returnedScreenshots / recordings
N/A
Checklist