Skip to content

Reuse check results for doctor JSON#342

Merged
codeforester merged 1 commit into
masterfrom
bug/328-20260531-doctor-json-check-results
May 31, 2026
Merged

Reuse check results for doctor JSON#342
codeforester merged 1 commit into
masterfrom
bug/328-20260531-doctor-json-check-results

Conversation

@codeforester
Copy link
Copy Markdown
Owner

Summary

  • Refactor basectl doctor --format json to build base findings from setup_collect_base_check_results.
  • Translate shared check results from ok booleans into doctor status values and reuse recovery text for JSON fixes.
  • Update doctor JSON tests to cover the shared machine-readable finding names.

Validation

  • bats cli/bash/commands/basectl/tests/doctor.bats
  • bash -n cli/bash/commands/basectl/subcommands/doctor.sh cli/bash/commands/basectl/tests/doctor.bats
  • env -u BASE_HOME HOME=/private/tmp/base-review-home BASE_TEST_PYTHON=/Users/rameshhp/.base.d/base/.venv/bin/python bin/base-test
  • git diff --check

Closes #328

@codeforester codeforester merged commit c3b2bee into master May 31, 2026
16 checks passed
@codeforester codeforester deleted the bug/328-20260531-doctor-json-check-results branch May 31, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

base_doctor_run_json duplicates base-environment check logic and will diverge from basectl check --format json

1 participant