Skip to content

fix: Minor fixes to the constructors for some of the vulkan-cpp objects #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SpinnerX merged 2 commits into from
May 27, 2026
Merged

fix: Minor fixes to the constructors for some of the vulkan-cpp objects #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82a5eb8
Fixing some of the default constructors
SpinnerX May 27, 2026
e4a7aab
Fixed mac git workflow naming convention
SpinnerX May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
version: "6.0"
secrets: inherit

mac-armv8:
mac:
uses: engine3d-dev/ci/.github/workflows/mac.yml@main
with:
package_name: "vulkan-cpp"
Expand Down
2 changes: 1 addition & 1 deletion vulkan-cpp/dyn/buffer.cppm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export namespace vk::dyn {

class buffer {
public:
buffer() = delete;
buffer() = default;

buffer(const VkDevice& p_device,
uint64_t p_device_size,
Expand Down
3 changes: 2 additions & 1 deletion vulkan-cpp/instance.cppm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ export namespace vk {
*/
class instance {
public:
instance() = delete("Disallow constructing empty vk::instance");
// instance() = delete("Disallow constructing empty vk::instance");
instance() = default;

/**
* @param p_config sets the application information that vulkan has
Expand Down
2 changes: 1 addition & 1 deletion vulkan-cpp/texture.cppm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export namespace vk {

class texture {
public:
texture() = delete;
texture() = default;

texture(const VkDevice& p_device,
const image_extent& p_extent,
Expand Down
Loading