robustness: follow up change for #21806

[henrybear327]

Address #21806 (comment)

The main idea is to not panic but return an error.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.78%. Comparing base (3fa0c55) to head (41d117f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

see 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21808      +/-   ##
==========================================
+ Coverage   69.74%   69.78%   +0.03%     
==========================================
  Files         449      449              
  Lines       38205    38205              
==========================================
+ Hits        26645    26660      +15     
+ Misses      10140    10113      -27     
- Partials     1420     1432      +12     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fa0c55...41d117f. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[serathius]

Please fix, recommend not to use if err := ...; err != nil {

../tests/robustness/main_test.go:98:6: shadow: declaration of "err" shadows declaration at line 91 (govet)
		if err := r.Finalize(t.Failed(), panicked); err != nil {
		   ^
../tests/robustness/main_test.go:104:5: shadow: declaration of "err" shadows declaration at line 91 (govet)
	if err := r.SaveEtcdData(); err != nil {
	   ^
2 issues:
* govet: 2

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: henrybear327
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[serathius]

Please fix

../tests/robustness/main_test.go:98:6: shadow: declaration of "err" shadows declaration at line 91 (govet)
		if err := r.Finalize(t.Failed(), panicked); err != nil {
		   ^
../tests/robustness/main_test.go:104:5: shadow: declaration of "err" shadows declaration at line 91 (govet)
	if err := r.SaveEtcdData(); err != nil {
	   ^

[henrybear327]

Please fix, recommend not to use if err := ...; err != nil {

../tests/robustness/main_test.go:98:6: shadow: declaration of "err" shadows declaration at line 91 (govet)
		if err := r.Finalize(t.Failed(), panicked); err != nil {
		   ^
../tests/robustness/main_test.go:104:5: shadow: declaration of "err" shadows declaration at line 91 (govet)
	if err := r.SaveEtcdData(); err != nil {
	   ^
2 issues:
* govet: 2

Got you, will keep in mind. Thanks.

[henrybear327]

Please fix

../tests/robustness/main_test.go:98:6: shadow: declaration of "err" shadows declaration at line 91 (govet)
		if err := r.Finalize(t.Failed(), panicked); err != nil {
		   ^
../tests/robustness/main_test.go:104:5: shadow: declaration of "err" shadows declaration at line 91 (govet)
	if err := r.SaveEtcdData(); err != nil {
	   ^

This PR is now not stacked on top of another PR, so this is not a problem anymore!

[henrybear327]

/retest

[henrybear327]

Rebased and resolved merge conflict.

[k8s-ci-robot]

@henrybear327: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-etcd-robustness-arm64	41d117f	link	true	/test pull-etcd-robustness-arm64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.