Add more context to warnings emitted from Django when unpickling objects#381
Open
Tenzer wants to merge 1 commit into
Open
Add more context to warnings emitted from Django when unpickling objects#381Tenzer wants to merge 1 commit into
Tenzer wants to merge 1 commit into
Conversation
When upgrading Django, Django will emit a warning whenever an object is being unpickled which was created with a different version of Django. This warning isn't very easy to action as it doesn't contain any context about what object it is or where it may have got the object from. The warning might look something like this: > WARNING [2019-04-25 09:41:48,525] warnings: /path/to/virtualenv/lib/python3.7/site-packages/django_redis/serializers/pickle.py:35: RuntimeWarning: Pickled model instance's Django version 2.1.8 does not match the current version 2.2. > return pickle.loads(value) This change will loop through each warning emitted during the deserialization of the cached item and append the cache key to the warning which at least would give some context as to why that is happening, so the warning message instead becomes: > WARNING [2019-04-25 09:41:48,525] warnings: /path/to/virtualenv/lib/python3.7/site-packages/django_redis/serializers/pickle.py:35: RuntimeWarning: Pickled model instance's Django version 2.1.8 does not match the current version 2.2. (cache key: :1:user) > return pickle.loads(value) given the cache key `user`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When upgrading Django, Django will emit a warning whenever an object is being
unpickled which was created with a different version of Django. This warning
isn't very easy to action as it doesn't contain any context about what object
it is or where it may have got the object from. The warning might look
something like this:
This change will loop through each warning emitted during the deserialization
of the cached item and append the cache key to the warning which at least would
give some context as to why that is happening, so the warning message instead
becomes:
given the cache key
user.