fix: accept and ignore close() kwargs from request_finished signal (#…#818
Open
mpasternak wants to merge 2 commits into
Open
fix: accept and ignore close() kwargs from request_finished signal (#…#818mpasternak wants to merge 2 commits into
mpasternak wants to merge 2 commits into
Conversation
…azzband#787) `RedisCache.close()` was forwarding `**kwargs` to `self.client.close()`, which since django-redis 6.0.0 (DefaultClient signature change in c7be6cc) takes no arguments. Django's `request_finished` signal passes `signal=` and `sender=`, so every request raised `TypeError: close() got an unexpected keyword argument 'signal'`. Also bumps the package to 6.0.1 and refreshes the CI/setup matrix: drop EOL Python 3.9/3.10 and Django 4.2/5.1; add Python 3.14 and Django 6.0 (Django 6.0 excluded on Python 3.11). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #818 +/- ##
========================================
- Coverage 38.2% 38.1% -0.0%
========================================
Files 48 48
Lines 3727 3731 +4
Branches 301 301
========================================
+ Hits 1420 1421 +1
- Misses 2006 2009 +3
Partials 301 301
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WisdomPill
requested changes
May 3, 2026
| django-version: | ||
| - '4.2' | ||
| - '5.1' | ||
| - '5.2' |
Member
There was a problem hiding this comment.
.ruff.toml needs to be updated to support python3.10 onwards
|
|
||
| [options] | ||
| python_requires = >=3.9 | ||
| python_requires = >=3.11 |
Member
There was a problem hiding this comment.
python 3.10 is still supported by Django 5.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…787)
RedisCache.close()was forwarding**kwargstoself.client.close(), which since django-redis 6.0.0 (DefaultClient signature change in c7be6cc) takes no arguments. Django'srequest_finishedsignal passessignal=andsender=, so every request raisedTypeError: close() got an unexpected keyword argument 'signal'.Also bumps the package to 6.0.1 and refreshes the CI/setup matrix: drop EOL Python 3.9/3.10 and Django 4.2/5.1; add Python 3.14 and Django 6.0 (Django 6.0 excluded on Python 3.11).
Fix #787