docs: add ListenerSet to SectionName interpretation table#4880
docs: add ListenerSet to SectionName interpretation table#4880apkatsikas wants to merge 2 commits into
Conversation
Signed-off-by: apkatsikas <apkatsikas@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: apkatsikas The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
|
Welcome @apkatsikas! |
|
Hi @apkatsikas. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/cc |
snorwin
left a comment
There was a problem hiding this comment.
@apkatsikas thanks for the PR, could you please run make generate.
Signed-off-by: apkatsikas <apkatsikas@gmail.com>
|
|
/test pull-gateway-api-verify |
|
@apkatsikas: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@snorwin it looks like committing the make generate output is causing the |
@snorwin I ran crdify locally and everything passes except the description check. Is there a way to handle this, or is this something that needs to be addressed in the check itself? |
|
@rikatz as we're often tweaking and refining descriptions, can we disable |
|
hum we probably can disable crdify, I may be able to take a look and disable it tomorrow. |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
LocalPolicyTargetReferenceWithSectionNamedocuments howSectionNameis interpreted forGateway,HTTPRoute, andService, but omitsListenerSet. SinceListenerSetlisteners are addressed by name viaSectionName, the same asGateway, it should appear in the table.Does this PR introduce a user-facing change?: