Skip to content

docs: add ListenerSet to SectionName interpretation table#4880

Open
apkatsikas wants to merge 2 commits into
kubernetes-sigs:mainfrom
apkatsikas:docs/listenerset-sectionname-policy-types
Open

docs: add ListenerSet to SectionName interpretation table#4880
apkatsikas wants to merge 2 commits into
kubernetes-sigs:mainfrom
apkatsikas:docs/listenerset-sectionname-policy-types

Conversation

@apkatsikas
Copy link
Copy Markdown

What type of PR is this?
/kind documentation

What this PR does / why we need it:

LocalPolicyTargetReferenceWithSectionName documents how SectionName is interpreted for Gateway, HTTPRoute, and Service, but omits ListenerSet. Since ListenerSet listeners are addressed by name via SectionName, the same as Gateway, it should appear in the table.

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: apkatsikas <apkatsikas@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels May 18, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: apkatsikas
Once this PR has been reviewed and has the lgtm label, please assign rikatz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented May 18, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: apkatsikas / name: apkatsikas (0676de3)

@k8s-ci-robot k8s-ci-robot requested review from danwinship and rikatz May 18, 2026 19:48
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @apkatsikas!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 18, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @apkatsikas. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 18, 2026
@snorwin
Copy link
Copy Markdown
Member

snorwin commented May 19, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 19, 2026
@snorwin
Copy link
Copy Markdown
Member

snorwin commented May 19, 2026

/cc

@k8s-ci-robot k8s-ci-robot requested a review from snorwin May 19, 2026 09:27
Copy link
Copy Markdown
Member

@snorwin snorwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apkatsikas thanks for the PR, could you please run make generate.

Signed-off-by: apkatsikas <apkatsikas@gmail.com>
@apkatsikas
Copy link
Copy Markdown
Author

@apkatsikas thanks for the PR, could you please run make generate.

7dabb28

@apkatsikas apkatsikas requested a review from snorwin May 19, 2026 15:10
@apkatsikas
Copy link
Copy Markdown
Author

/test pull-gateway-api-verify

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@apkatsikas: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gateway-api-verify 7dabb28 link true /test pull-gateway-api-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@apkatsikas
Copy link
Copy Markdown
Author

@snorwin it looks like committing the make generate output is causing the verify-crdify check to fail. Is that expected behavior for a doc-only change like this, or should I not be committing the CRD YAML regeneration here?

@apkatsikas
Copy link
Copy Markdown
Author

@apkatsikas the API docs are part of the CRDs, so they need to be committed together.

@snorwin I ran crdify locally and everything passes except the description check. Is there a way to handle this, or is this something that needs to be addressed in the check itself?

@snorwin
Copy link
Copy Markdown
Member

snorwin commented May 19, 2026

@rikatz as we're often tweaking and refining descriptions, can we disable verify-crdify on descriptions?

@apkatsikas
Copy link
Copy Markdown
Author

Hi @snorwin and @rikatz, any updates on this?

@rikatz
Copy link
Copy Markdown
Member

rikatz commented May 27, 2026

hum we probably can disable crdify, I may be able to take a look and disable it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants